Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slash from void HTML elements #51646

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Remove trailing slash from void HTML elements #51646

wants to merge 16 commits into from

Commits on Apr 23, 2024

  1. Remove trailing slash from void HTML elements

    @ahukkanen
    ahukkanen committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    adddde4 View commit details
    Browse the repository at this point in the history

  2. Ensure proper handling of the open argument regardless of config 

    Always respect the `open` argument regardless of the value of the
`void_element_trailing_slash` configuration.
    @ahukkanen
    ahukkanen committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1483409 View commit details
    Browse the repository at this point in the history

  3. Fix broken tests for the TagHelper

    @ahukkanen
    ahukkanen committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    edd75cb View commit details
    Browse the repository at this point in the history

  4. Test the trailing slash on void elements

    @ahukkanen
    ahukkanen committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f273265 View commit details
    Browse the repository at this point in the history

  5. Add CHANGELOG entry

    @ahukkanen
    ahukkanen committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    5848407 View commit details
    Browse the repository at this point in the history

  6. Fix more broken tests

    @ahukkanen
    ahukkanen committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c562708 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Refert the rails-ujs JS files

    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ee8e8d5 View commit details
    Browse the repository at this point in the history

  2. Move the CHANGELOG item as first in the list

    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4b11ace View commit details
    Browse the repository at this point in the history

  3. Ensure text helper line breaks are respecting the trailing slash

    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5be711e View commit details
    Browse the repository at this point in the history

  4. Ensure the utf8_enforcer_tag is respecting the trailing slash

    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d2b41e3 View commit details
    Browse the repository at this point in the history

  5. Default the trailing slash config to true for older configurations 

    - When using `load_defaults "7.1"` or below, default the new
  configuration to `true`
- When using `load_defaults "7.2"` or higher, default the new
  configuration to `false`
    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    fa7bb74 View commit details
    Browse the repository at this point in the history

  6. Add documentation for config.action_view.void_element_trailing_slash

    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    bc76c55 View commit details
    Browse the repository at this point in the history

  7. Correct the tag suffix for void elements generated by TagBuilder

    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    dcf7b87 View commit details
    Browse the repository at this point in the history

  8. Fix the versioned default values docs

    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    cb859e4 View commit details
    Browse the repository at this point in the history

  9. Add the new config to the new framework defaults template

    @ahukkanen
    ahukkanen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    80f905b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Apply review recommendation regarding default configuration values

    @ahukkanen
    ahukkanen committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1a47028 View commit details
    Browse the repository at this point in the history