-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Rendering for Guides #51613
base: main
Are you sure you want to change the base?
RTL Rendering for Guides #51613
Changes from 5 commits
8e542e8
b0d0af5
f7a7cf8
aa45e9e
58dbf69
c022085
9182dad
196635c
91ddfcc
548271a
ae881dc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -17,19 +17,27 @@ body.guide { | |||||||
|
||||||||
-webkit-tap-highlight-color:rgba(38, 27, 35, 0); | ||||||||
|
||||||||
// ---------------------------------------------------------------------------- | ||||||||
html.translated-rtl & { | ||||||||
direction: rtl; | ||||||||
|
||||||||
p { | ||||||||
text-align: right; | ||||||||
} | ||||||||
} | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is similar/related to the font declarations at the bottom, and those also use How about something like this at the bottom: html[dir="rtl"] {
body.guide {
// these declarations
}
&:lang("ar"), &:lang("fa") {
body.guide {
// ... font declarations
}
}
&:lang("foo")...
} So we have less spread changes related to dir=rtl. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've done this where the items are simple. Where things are layout related or media query I've left them in place as it seems more logical and easier to understand. ae881dc There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool, yeah I was mainly looking for this block really which seemed super related to the one at the bottom when I reviewed. 👍 |
||||||||
|
||||||||
// ---------------------------------------------------------------------------- | ||||||||
Comment on lines
+20
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like typo, let's revert.
Suggested change
|
||||||||
// Typographic Baseline | ||||||||
// ---------------------------------------------------------------------------- | ||||||||
|
||||||||
:root { | ||||||||
font-family: Inter, sans-serif; | ||||||||
font-family: Inter, "Noto Sans Arabic", "Heebo", sans-serif; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should these only be applied via the lang attribute (i.e. around line 830-832 https://github.com/rails/rails/pull/51613/files#diff-52d9905acf20170cc789b2c2fe8833cdc455790f77796a2a0e42ec07ba27f209R830-R832) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a few more mentions of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cleaned up in 91ddfcc |
||||||||
font-feature-settings: 'liga' 1, 'calt' 1; /* fix for Chrome */ | ||||||||
} | ||||||||
@supports (font-variation-settings: normal) { | ||||||||
:root { font-family: InterVariable, sans-serif; } | ||||||||
} | ||||||||
|
||||||||
font-family: Inter, sans-serif; | ||||||||
font-family: Inter, "Noto Sans Arabic", "Heebo", sans-serif; | ||||||||
font-size: 1rem; /* 16px */ | ||||||||
font-style: normal; | ||||||||
font-weight: 400; | ||||||||
|
@@ -56,8 +64,9 @@ body.guide { | |||||||
hyphenate-limit-last: always; | ||||||||
|
||||||||
margin: 0 0 0.75em 0; // Space after paragraph | ||||||||
text-align: left; | ||||||||
|
||||||||
:where(body[dir="ltr"]) & { text-align: left; } | ||||||||
:where(body[dir="rtl"]) & { text-align: right; } | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have moved these to the It's a simple change to the JS to target the body, change line 111: // from
mutation.target.dir =
// to
document.querySelector("body").dir = For instance, I believe some of these changes broke a few things like the icon positions: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed in c022085 |
||||||||
} // p | ||||||||
|
||||||||
// Links | ||||||||
|
@@ -107,7 +116,9 @@ body.guide { | |||||||
color: #fff; | ||||||||
font-size: 0.875em; | ||||||||
padding: 0.5em; | ||||||||
text-align: left; | ||||||||
|
||||||||
:where(body[dir="ltr"]) & { text-align: left; } | ||||||||
:where(body[dir="rtl"]) & { text-align: right; } | ||||||||
} | ||||||||
|
||||||||
tr { | ||||||||
|
@@ -125,7 +136,7 @@ body.guide { | |||||||
// TODO: media queries to increase font size, current sizes are for desktop, so drop base to mobile appropriate and MQ up twice (min width 60/120 em, minheight 30/60em) | ||||||||
h1 { | ||||||||
color: $rf-brand; | ||||||||
font-family: 'Calibre', sans-serif; | ||||||||
font-family: 'Calibre', "Noto Sans Arabic", "Heebo", sans-serif; | ||||||||
font-size: 3rem; /* 48px */ | ||||||||
font-weight: 700; /* Light */ | ||||||||
line-height: 1em; | ||||||||
|
@@ -135,7 +146,7 @@ body.guide { | |||||||
} // h1 | ||||||||
|
||||||||
h2 { | ||||||||
font-family: 'Calibre', sans-serif; | ||||||||
font-family: 'Calibre', "Noto Sans Arabic", "Heebo", sans-serif; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here are the other fonts I mentioned, I think these would be covered by the declarations at the bottom. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cleaned up in 91ddfcc |
||||||||
font-size: 2.25rem; // Calibre is smaller than inter at the same size | ||||||||
font-weight: 700; /* Bold */ | ||||||||
|
||||||||
|
@@ -261,10 +272,12 @@ body.guide { | |||||||
} // dl | ||||||||
|
||||||||
// :where(&[dir="ltr"]) dd { margin-left: 1.5em; } | ||||||||
// :where(&[dir="rtl"]) dd { margin-right: 1.5em; } | ||||||||
// :where(&[dir="rtl"]) dd, | ||||||||
// html.translated-rtl dd { margin-right: 1.5em; } | ||||||||
|
||||||||
// :where(&[dir="ltr"]) :is(dd) { margin-left: 0; padding-left: 0; } | ||||||||
// :where(&[dir="rtl"]) :is(dd) { margin-right: 0; padding-right: 0; } | ||||||||
// :where(&[dir="rtl"]) :is(dd), | ||||||||
// html.translated-rtl :is(dd) { margin-right: 0; padding-right: 0; } | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's remove these commented pieces. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed in c022085 |
||||||||
|
||||||||
li { | ||||||||
margin-bottom: 0.5em; | ||||||||
|
@@ -274,7 +287,7 @@ body.guide { | |||||||
|
||||||||
pre, code { | ||||||||
font-size: 1rem; | ||||||||
font-family: "IBM Plex Mono", "Anonymous Pro", "Inconsolata", "Menlo", "Consolas", "Bitstream Vera Sans Mono", "Courier New", monospace; | ||||||||
font-family: "IBM Plex Mono", "Anonymous Pro", "Inconsolata", "Menlo", "Consolas", "Bitstream Vera Sans Mono", "Courier New", monospace !important; | ||||||||
line-height: 1.5; | ||||||||
margin: 1em 0; | ||||||||
overflow: auto; | ||||||||
|
@@ -325,12 +338,19 @@ body.guide { | |||||||
padding: 1em; | ||||||||
|
||||||||
:where(body[dir="ltr"]) & { text-align: left; } | ||||||||
:where(body[dir="rtl"]) & { text-align: right; } | ||||||||
:where(body[dir="rtl"]) &, | ||||||||
html.translated-rtl & { text-align: right; } | ||||||||
|
||||||||
@include media('>desktop') { // 1024 | ||||||||
max-width: calc(55rem + 420px); | ||||||||
margin: 0 auto; | ||||||||
padding-right: 470px; | ||||||||
|
||||||||
:where(body[dir="rtl"]) &, | ||||||||
html.translated-rtl & { | ||||||||
padding-right: 1.5em; | ||||||||
padding-left: 470px; | ||||||||
} | ||||||||
} | ||||||||
} // .wrapper | ||||||||
|
||||||||
|
@@ -439,7 +459,7 @@ body.guide { | |||||||
background-repeat: no-repeat; | ||||||||
background-position: top center; | ||||||||
display: inline-block; | ||||||||
font-family: 'Calibre', sans-serif; | ||||||||
font-family: 'Calibre', "Noto Sans Arabic", "Heebo", sans-serif; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another font declaration... not sure if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cleaned up in 91ddfcc |
||||||||
font-size: 2.25rem; | ||||||||
font-weight: 700; | ||||||||
margin: 0 auto; | ||||||||
|
@@ -586,7 +606,8 @@ body.guide { | |||||||
padding-bottom: 0.125em; | ||||||||
|
||||||||
:where(body[dir="ltr"]) & { background-position: right top; padding-right: 1em; } | ||||||||
:where(body[dir="rtl"]) & { background-position: left top; padding-left: 1em; } | ||||||||
:where(body[dir="rtl"]) &, | ||||||||
html.translated-rtl & { background-position: left top; padding-left: 1em; } | ||||||||
} | ||||||||
|
||||||||
|
||||||||
|
@@ -606,7 +627,8 @@ body.guide { | |||||||
z-index: 10; | ||||||||
|
||||||||
:where(body[dir="ltr"]) & { left: auto; right: 50px; } | ||||||||
:where(body[dir="rtl"]) & { left: 50px; right: auto; } | ||||||||
:where(body[dir="rtl"]) &, | ||||||||
html.translated-rtl & { left: 50px; right: auto; } | ||||||||
|
||||||||
&.visible { | ||||||||
display: block !important; | ||||||||
|
@@ -622,9 +644,11 @@ body.guide { | |||||||
.guides-section { | ||||||||
flex: auto; | ||||||||
margin: 0 2em 0.5em 0; | ||||||||
text-align: left; | ||||||||
width: 33%; | ||||||||
|
||||||||
:where(body[dir="ltr"]) & { text-align: left; } | ||||||||
:where(body[dir="rtl"]) & { text-align: right; } | ||||||||
|
||||||||
dt, dd { | ||||||||
font-weight: 400 !important; | ||||||||
font-size: 0.825rem; | ||||||||
|
@@ -707,6 +731,11 @@ body.guide { | |||||||
right: 50px; | ||||||||
max-height: calc(100vh - 200px); | ||||||||
width: 400px; | ||||||||
|
||||||||
:where(body[dir="rtl"]) &, | ||||||||
html.translated-rtl & { | ||||||||
right: auto; left: 50px; | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
&.guide-index { | ||||||||
|
@@ -795,4 +824,27 @@ body.guide { | |||||||
} | ||||||||
} | ||||||||
|
||||||||
} // body.guide | ||||||||
} // body.guide | ||||||||
|
||||||||
html.translated-rtl:lang("ar", "fa") { | ||||||||
body.guide { | ||||||||
h1, h2, h3, h4, h5, h6, p, dl, dd, dt, ul, ol, li { | ||||||||
font-family: "Noto Sans Arabic", sans-serif; | ||||||||
font-optical-sizing: auto; | ||||||||
font-weight: 400; | ||||||||
font-style: normal; | ||||||||
font-variation-settings: "wdth" 100; | ||||||||
} | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's just use the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed in c022085 |
||||||||
html.translated-rtl:lang("he", "iw") { | ||||||||
body.guide { | ||||||||
h1, h2, h3, h4, h5, h6, p, dl, dd, dt, ul, ol, li { | ||||||||
font-family: "Heebo", sans-serif; | ||||||||
font-optical-sizing: auto; | ||||||||
font-weight: 400; | ||||||||
font-style: normal; | ||||||||
} | ||||||||
} | ||||||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,8 @@ intermediate whitespace looks uniform. */ | |
|
||
// Padding and spacing for LTR vs RTL langauge defaults | ||
:where(body[dir="ltr"]) & { background-position: 10px 10px; padding-right: 1em !important; padding-left: 56px !important; } | ||
:where(body[dir="rtl"]) & { background-position: calc(100% - 10px) 10px; padding-right: 56px !important; padding-left: 1em !important; } | ||
:where(body[dir="rtl"]) &, | ||
html.translated-rtl & { background-position: calc(100% - 10px) 10px; padding-right: 56px !important; padding-left: 1em !important; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can probably the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 196635c |
||
|
||
/* Remove bottom margin of paragraphs in special boxes, otherwise they get a | ||
spurious blank area below with the box background. */ | ||
|
@@ -39,6 +40,8 @@ intermediate whitespace looks uniform. */ | |
background-color: $gray-900; | ||
min-height: auto; // remove if icon is restored | ||
padding-left: 1em !important; // remove if icon is restored | ||
direction: ltr !important; | ||
text-align: left !important; | ||
|
||
pre {margin: 0;} | ||
|
||
|
@@ -52,9 +55,9 @@ intermediate whitespace looks uniform. */ | |
padding: 0.25em 0.5em !important; | ||
position: absolute; | ||
bottom: 10px; | ||
:where(body[dir="ltr"]) & { right: 10px; } | ||
:where(body[dir="rtl"]) & { left: 10px; } | ||
right: 10px; | ||
text-transform: uppercase; | ||
width: auto; | ||
} // button.clipboard-button | ||
} // &.code | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<!doctype html> | ||
<html lang="en"> | ||
<html dir="<%= @direction %>" lang="en"> | ||
|
||
<head> | ||
<meta charset="utf-8"> | ||
|
@@ -25,10 +25,15 @@ | |
<meta property="og:image" content="https://avatars.githubusercontent.com/u/4223" /> | ||
<meta property="og:type" content="website" /> | ||
|
||
<link rel="preconnect" href="https://fonts.googleapis.com"> | ||
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
<link href="https://fonts.googleapis.com/css2?family=Noto+Sans+Arabic:wght@100..900&display=swap" rel="stylesheet"> | ||
<link href="https://fonts.googleapis.com/css2?family=Heebo:wght@100..900&family=Noto+Sans+Arabic:wght@100..900&display=swap" rel="stylesheet"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will these cause the fonts to be downloaded upfront, or just they're actually referenced/needed? (i.e. for those specific languages, assuming we make the change to only refer to them there) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They load on page load. Not sure how we could only include that font for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jathayde well, simple <% if @direction == "rtl" %>
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Noto+Sans+Arabic:wght@100..900&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/css2?family=Heebo:wght@100..900&family=Noto+Sans+Arabic:wght@100..900&display=swap" rel="stylesheet">
<% endif %> Also, you can use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @idangoldman unfortunately because we may swap We'd have to do it via JS and manually append the link tags when the translation changes. I don't know much/enough about those system fonts for this though, @jathayde do you / have you tried? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @carlosantoniodasilva yeah fair point... After looking into the codebase, I saw that all the currently used fonts in the guides are declaired as @jathayde, what about adding the new fonts support into that file as Stay with me, it's a bit long -> /* RTL Fonts Support for Arabic */
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:100; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-Thin.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:100; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-ThinItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:200; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-ExtraLight.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:200; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-ExtraLightItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:300; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-Light.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:300; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-LightItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:400; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-Regular.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:400; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-Italic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:500; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-Medium.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:500; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-MediumItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:600; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-SemiBold.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:600; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-SemiBoldItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:700; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-Bold.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:700; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-BoldItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:800; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-ExtraBold.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:800; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-ExtraBoldItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:normal; font-weight:900; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-Black.woff2?v=4.0") format("woff2"); }
@font-face { font-family:"Noto Sans Arabic"; font-style:italic; font-weight:900; font-display:swap; unicode-range: U+0600-06FF, U+0750-077F, U+08A0-08FF, U+FB50-FDFF, U+FE70-FEFF; src:url("https://rubyonrails.org/assets/fonts/NotoSansArabic-BlackItalic.woff2?v=4.0") format("woff2"); }
/* RTL Fonts Support for Hebrew */
@font-face { font-family:Heebo; font-style:normal; font-weight:100; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-Thin.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:100; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-ThinItalic.woff2?v=4.0") format("woff2"); }`
@font-face { font-family:Heebo; font-style:normal; font-weight:200; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-ExtraLight.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:200; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-ExtraLightItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:normal; font-weight:300; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-Light.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:300; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-LightItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:normal; font-weight:400; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-Regular.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:400; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-Italic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:normal; font-weight:500; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-Medium.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:500; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-MediumItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:normal; font-weight:600; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-SemiBold.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:600; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-SemiBoldItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:normal; font-weight:700; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-Bold.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:700; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-BoldItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:normal; font-weight:800; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-ExtraBold.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:800; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-ExtraBoldItalic.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:normal; font-weight:900; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-Black.woff2?v=4.0") format("woff2"); }
@font-face { font-family:Heebo; font-style:italic; font-weight:900; font-display:swap; unicode-range: U+0590-05FF, U+FB1D-FB4F; src:url("https://rubyonrails.org/assets/fonts/Heebo-BlackItalic.woff2?v=4.0") format("woff2"); } One thing, I haven't found how the fonts are generated/downloaded/stored on rubyonrails.org. Another thing, References:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Playing with this right now and the only issue I've got is that Google bypasses this step for you when you serve from their CDN. We could download and host the fonts, but without doing that, I don't see a clear way to limit to unicode ranges. @carlosantoniodasilva do we want to try and serve these from our domain? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, I think we could leverage a variable font to reduce the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jathayde I don't think we want to include all of those font-faces on rubyonrails.org . We did that for the main guides fonts, but this seems very specific use case to store there, we should leverage google instead. What I'd prefer is just not load up those fonts upfront, but instead when they swap to a font that does require them. We could perhaps use JS to programmatically load the fonts from Google (by adding the tags to the head) when they select one of the fonts that require it? I don't think this is a blocker, but if that sounds like it could be okay I could look into it. |
||
|
||
<meta name="theme-color" content="#C81418"> | ||
</head> | ||
|
||
<body dir="<%= @direction %>" class="guide"> | ||
<body class="guide"> | ||
<nav id="topNav" aria-label="Secondary"> | ||
<div class="wrapper"> | ||
<strong class="more-info-label">More at <a href="https://rubyonrails.org/">rubyonrails.org:</a> </strong> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we eliminate the usage of
.translated-rtl
from the CSS, and rely on thedir
alone?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in c022085