Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent ENV.fetch style #51094

Closed
wants to merge 2 commits into from

Conversation

anonychun
Copy link
Contributor

Motivation / Background

Simplify using ENV.fetch in places that do not require a block to make it more consistent.

Detail

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@zzak
Copy link
Member

zzak commented Feb 15, 2024

Please check the history before suggesting such changes, easy mistake to make. :)
See #49244.

@zzak zzak closed this Feb 15, 2024
@anonychun
Copy link
Contributor Author

Please check the history before suggesting such changes, easy mistake to make. :) See #49244.

Actually this commit is inspires me 99d3b52

But, thank you

@zzak
Copy link
Member

zzak commented Feb 15, 2024

I can understand why that is confusing.

As this was technically a cosmetic change, my only guess is that because this file was recently updated in #50669 that falls under "while we were there we could have cleaned that up".

But also, my feeling is that the guidelines are there for contributors to reduce the overhead of maintainers, and a member of the core team has more tolerance.

Thank you for your PR, and I hope you will continue to be inspired to contribute to Rails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants