Move Transfer-Encoding chunked test to Action Pack #50632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on [another PR][1], I found that removing the Transfer-Encoding conditionals did not result in any failing tests in Action Pack. This was surprising to me until I found that there was a test for this behavior in Railties. However, nothing about the test really depends on having a full Rails application or the Railties test suite. This commit moves the test into Action Pack to simplify/speedup the test (no need to build a full app) as well as keeping the test closer to the actual behavior being tested. [1]: 0c334b4
skipkayhil
force-pushed
the
hm-move-chunk-test-to-actionpack
branch
from
3932175
to
a03a854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Ref #47336
While working on another PR, I found that removing the Transfer-Encoding conditionals did not result in any failing tests in Action Pack. This was surprising to me until I found that there was a test for this behavior in Railties. However, nothing about the test really depends on having a full Rails application or the Railties test suite.
Detail
This commit moves the test into Action Pack to simplify/speedup the test (no need to build a full app) as well as keeping the test closer to the actual behavior being tested.