Treat as: :html tests request params as :url_encoded_form
#50390
+26
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2023
|
@rafaelfranca could you review this, since you've reviewed and merged #47144? |
seanpdoyle
force-pushed
the
issue-50345
branch
2 times, most recently
from
fed510e
to
ff91bc3
Compare
seanpdoyle
changed the title
as: :html in IntegrationTestas: :html tests request params as :url_encoded_form
seanpdoyle
force-pushed
the
issue-50345
branch
2 times, most recently
from
091e925
to
68d409f
Compare
Closes [rails#50345][] First, handle the exception mentioned in [rails#50345][]: ``` BugTest#test_params_with_htm_content_type: NoMethodError: undefined method `to_html' for {:name=>"Muad'Dib"}:Hash .../actionpack/lib/action_dispatch/testing/request_encoder.rb:39:in `encode_params' .../actionpack/lib/action_dispatch/testing/integration.rb:251:in `process' ``` Calls with `as: :html` result in a `NoMethodError` because `Hash#to_html` does not exist. Passing `as: :html` implies that the request parameters will come from a `POST` body encoded as `text/html`. That isn't entirely true -- browsers will encode `POST` parameters as with the `Content-Type:` header set to either [application/x-www-form-urlencoded][] or [multipart/form-data][]. This commit skips setting the `CONTENT_TYPE` Rack header when processed with `as: :html`. To account for that, extend the `RequestEncoder` constructor to accept a `content_type `argument to use when provided. When omitted, continue to fall back to the provided MIME type. Extend the default `:html` encoder configuration to default to submitting with `Content-Type: x-www-form-urlencoded`. [rails#50345]: rails#50345 [application/x-www-form-urlencoded]: https://developer.mozilla.org/en-US/docs/Learn/Forms/Sending_and_retrieving_form_data#the_post_method [multipart/form-data]: https://developer.mozilla.org/en-US/docs/Learn/Forms/Sending_and_retrieving_form_data#the_enctype_attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Closes #50345
Detail
First, handle the exception mentioned in #50345:
Calls with
as: :htmlresult in aNoMethodErrorbecauseHash#to_htmldoes not exist.Passing
as: :htmlimplies that the request parameters will come from aPOSTbody encoded astext/html. That isn't entirely true -- browserswill encode
POSTparameters as with theContent-Type:header set toeither application/x-www-form-urlencoded or multipart/form-data.
This commit skips setting the
CONTENT_TYPERack header when processedwith
as: :html.To account for that, extend the
RequestEncoderconstructor to accept acontent_typeargument to use when provided. When omitted, continue tofall back to the provided MIME type. Extend the default
:htmlencoderconfiguration to default to submitting with
Content-Type: x-www-form-urlencoded.Before submitting the PR make sure the following are checked:
[Fix #issue-number]