Remove all deprecated code #49624
Merged
Remove all deprecated code #49624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelfranca I removed |
|
Thanks! I'll apply your commit to my branch |
|
Should we remove |
|
Yes. I'll remove every single deprecation. |
4 tasks
nvasilevski
reviewed
Nov 14, 2023
21 tasks
rafaelfranca
force-pushed
the
rm-deprecations
branch
3 times, most recently
from
0eb3110
to
e821812
Compare
rafaelfranca
force-pushed
the
rm-deprecations
branch
from
7c43f4c
to
640d066
Compare
rafaelfranca
force-pushed
the
rm-deprecations
branch
3 times, most recently
from
c594b14
to
16d6ddd
Compare
When `to_time_preserves_timezone` was set to `false`, `to_time` would return a `Time` object with local timezone. This behavior has been removed.
… `ActiveSupport::LogSubscriber::BOLD`
… in `ActiveSupport::LogSubscriber#color`
This change was never released on 7.1, so we can't remove it on 7.2.
…ng a deprecator - `deprecate` - `deprecate_constant` - `ActiveSupport::Deprecation::DeprecatedObjectProxy.new` - `ActiveSupport::Deprecation::DeprecatedInstanceVariableProxy.new` - `ActiveSupport::Deprecation::DeprecatedConstantProxy.new` - `assert_deprecated` - `assert_not_deprecated` - `collect_deprecations`
…`ActiveSupport::Notifications::Event#parent_of?`
rafaelfranca
force-pushed
the
rm-deprecations
branch
from
6614be3
to
96d918b
Compare
rafaelfranca
force-pushed
the
rm-deprecations
branch
from
96d918b
to
b35df00
Compare
4 tasks
flavorjones
added a commit
to flavorjones/rails
that referenced
this pull request
May 6, 2024
PR rails#49624 contained commit 0c76f17 which mistakenly used backticks instead of normal string quotes. This is easy to miss, but risks introducing a security vulnerability into the codebase. Forcing the use of `%x()` should make it more obvious visually where the command literals are. See related rails#51739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all code deprecated in 7.1.