Add an option to start rails console in sandbox mode by default #48984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouichi
force-pushed
the
sandbox-by-default
branch
from
6f70f62
to
c0f8d14
Compare
shouichi
force-pushed
the
sandbox-by-default
branch
from
c0f8d14
to
f115e7b
Compare
|
Tests are broken. Can you take a look? |
shouichi
force-pushed
the
sandbox-by-default
branch
from
f115e7b
to
7aa52c6
Compare
To avoid accidental writing to the production database, I always start rails console in sandbox mode. I only start rails console in non-sandbox mode when I'm sure I want to write to the production database. `sandbox_by_default` option is added to start rails console in sandbox mode by default. With this option turned on, `--no-sandbox` must be specified to start rails in non-sandbox mode. Note that this option is ignored when rails environment is development or test.
shouichi
force-pushed
the
sandbox-by-default
branch
from
7aa52c6
to
b8decf7
Compare
|
@rafaelfranca Fixed the tests. Could you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid accidental writing to the production database, I always start rails console in sandbox mode. I only start rails console in non-sandbox mode when I'm sure I want to write to the production database.
sandbox_by_defaultoption is added to start rails console in sandbox mode by default. With this option turned on,--no-sandboxmust be specified to start rails in non-sandbox mode.Note that this option is ignored when rails environment is development or test.