Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix address when IPAddr of CIDR is encoded with JSON #46007

Closed
wants to merge 1 commit into from

Conversation

taketo1113
Copy link
Contributor

@taketo1113 taketo1113 commented Sep 12, 2022

Motivation / Background

This Pull Request has been created because JSON encoded IPAddr/CIDR is removed the prefix address.
It unable to deserialize IPAddr/CIDR value.

Detail

This Pull Request changes that IPAddr of CIDR is encoded with JSON add prefix address.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • There are no typos in commit messages and comments.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Feature branch is up-to-date with main (if not - rebase it).
  • Pull request only contains one commit for bug fixes and small features. If it's a larger feature, multiple commits are permitted but must be descriptive.
  • Tests are added if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.
  • PR is not in a draft state.
  • CI is passing.

@yahonda
Copy link
Member

yahonda commented Sep 12, 2022

Closing this pull request as per discussed #46006 (comment) This issue has been raised at flori/json#503 .

@yahonda yahonda closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON encoded IPAddr/CIDR remove the prefix address
2 participants