Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag helper regression #45027

Merged
merged 1 commit into from May 5, 2022
Merged

Fix tag helper regression #45027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions actionview/test/template/tag_helper_test.rb
View file
Open in desktop
Expand Up @@ -201,6 +201,8 @@ def test_content_tag
content_tag(:p, "<script>evil_js</script>")
assert_equal "<p><script>evil_js</script></p>",
content_tag(:p, "<script>evil_js</script>", nil, false)
assert_equal "<div @click=\"triggerNav()\">test</div>",
content_tag(:div, "test", "@click": "triggerNav()")
end

def test_tag_builder_with_content
Expand Down
2 changes: 1 addition & 1 deletion activesupport/lib/active_support/core_ext/string/output_safety.rb
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@ module Util
JSON_ESCAPE_REGEXP = /[\u2028\u2029&><]/u

# Following XML requirements: https://www.w3.org/TR/REC-xml/#NT-Name
TAG_NAME_START_REGEXP_SET = ":A-Z_a-z\u{C0}-\u{D6}\u{D8}-\u{F6}\u{F8}-\u{2FF}\u{370}-\u{37D}\u{37F}-\u{1FFF}" \
TAG_NAME_START_REGEXP_SET = "@:A-Z_a-z\u{C0}-\u{D6}\u{D8}-\u{F6}\u{F8}-\u{2FF}\u{370}-\u{37D}\u{37F}-\u{1FFF}" \
tenderlove marked this conversation as resolved.
Show resolved Hide resolved
"\u{200C}-\u{200D}\u{2070}-\u{218F}\u{2C00}-\u{2FEF}\u{3001}-\u{D7FF}\u{F900}-\u{FDCF}" \
"\u{FDF0}-\u{FFFD}\u{10000}-\u{EFFFF}"
TAG_NAME_START_REGEXP = /[^#{TAG_NAME_START_REGEXP_SET}]/
Expand Down