Rename serviceName to directUploadToken in AS' DirectUpload

[julianrubisch]

Summary

in ActiveStorage's DirectUpload class, one parameter was (presumably) incorrectly named serviceName, while the BlobRecord class, which it is passed into, refers to it as directUploadToken. I think the latter is correct and the first is a bit misleading, since the Rails Guides refer to it as token, too.

[p8]

Hi @julianrubisch Thanks for contributing to Rails!

This got added in #38957.
I think you are correct as it seems that everywhere a DirectUpload is instantiated
an uploadToken is passed instead of a serviceName:

rails/activestorage/app/assets/javascripts/activestorage.js

Line 646 in 05bf8dc

this.directUpload = new DirectUpload(this.file, this.url, this.directUploadToken, this.attachmentName, this);

rails/actiontext/app/assets/javascripts/actiontext.js

Line 649 in fb36712

this.directUpload = new DirectUpload(this.file, this.url, this.directUploadToken, this.attachmentName, this);

rails/actiontext/app/javascript/actiontext/attachment_upload.js

Line 7 in 32228ff

this.directUpload = new DirectUpload(attachment.file, this.directUploadUrl, this.directUploadToken, this.attachmentName, this)

cc-ing @DmitryTsepelev as the original author of that PR.

[DmitryTsepelev]

Good catch!

[p8]

@julianrubisch Sorry, closing this as this feature is getting reverted and rewritten. See #44287