Stop failing GSRF token generation when session is disabled #43427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
remove-csrf-session-error
branch
from
f8cbddf
to
b1015d9
Compare
In theory this should have warned early that the CSRF check will fail, which would have been less puzzling for the developer. However there are several cases where we render forms but the session is inacessible. That's the case of turbo (hotwired/turbo-rails#243) as well as some others. So unless we figure a proper way to detect these cases, we're better to not cause this error. Writing to a disabled session directly will still raise, this only silence it for the specific case of CSRF.
casperisfine
force-pushed
the
remove-csrf-session-error
branch
from
b1015d9
to
4e3504f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: hotwired/turbo-rails#243
In theory this should have warned early that the CSRF check
will fail, which would have been less puzzling for the developer.
However there are several cases where we render forms but the session
is inacessible. That's the case of turbo (hotwired/turbo-rails#243)
as well as some others.
So unless we figure a proper way to detect these cases, we're better
to not cause this error.
Writing to a disabled session directly will still raise, this
only silence it for the specific case of CSRF.