Fix migration compatibility for default precision value on datetime columns (Round 2) #42631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertomiranda
changed the title
…olumns (Round 2) add test cases on default precision from 4.2 to 6.1 Fix compatibility on rails 6.0 Fix compatibility from 5.2 to 4.2
robertomiranda
force-pushed
the
compatibily-fix
branch
from
7d5c443
to
06b026f
Compare
|
👍 I've tested this patch against our CI and it fixes the issue 🙇 |
|
Thank you for your effort @robertomiranda 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix migration compatibility for default precision value on datetime columns
Why
Microseconds precision is the new default and was introduced on #42297, but in #42606 I found a compatibility issue. Another compatibility issue has been raised in #42606 (comment). ActiveRecord::Migration::Compatibility should prevent the introduction of this new behaviour on previous versions to 7.0.
How
t.datimecompatibility is broken from 4.2 to 6.0,columnmethod for Rails onV6_0class cddfc07 to fix the compatibility on Rails 6.0columnmethod behaviour on the classV5_2Fixing compatibility on rails version from 4.2 to 5.2cc @guilleiguaran @zzak @ghiculescu @Tonkpils