Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for RUBY_VERSION 3.1.0dev #41902

Closed
wants to merge 1 commit into from
Closed

Update dependencies for RUBY_VERSION 3.1.0dev #41902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 10 additions & 10 deletions Gemfile.lock
View file
Open in desktop
Expand Up @@ -158,18 +158,18 @@ GEM
bcrypt (3.1.16-java)
beaneater (1.0.0)
benchmark-ips (2.8.4)
blade (0.7.1)
blade (0.7.2)
activesupport (>= 3.0.0)
blade-qunit_adapter (~> 2.0.1)
blade-qunit_adapter (>= 2.0.1)
coffee-script
coffee-script-source
curses (~> 1.0.0)
curses (>= 1.4.0)
eventmachine
faye
sprockets (>= 3.0)
thin (>= 1.6.0)
thor (>= 0.19.1)
useragent (~> 0.16.7)
useragent (>= 0.16.7)
blade-qunit_adapter (2.0.1)
bootsnap (1.5.1)
msgpack (~> 1.0)
Expand Down Expand Up @@ -198,7 +198,7 @@ GEM
crack (0.4.5)
rexml
crass (1.0.6)
curses (1.0.2)
curses (1.4.0)
daemons (1.3.1)
dalli (2.7.11)
dante (0.2.0)
Expand Down Expand Up @@ -354,16 +354,16 @@ GEM
connection_pool (~> 2.2)
nio4r (2.5.4)
nio4r (2.5.4-java)
nokogiri (1.11.1)
nokogiri (1.11.3)
mini_portile2 (~> 2.5.0)
racc (~> 1.4)
nokogiri (1.11.1-java)
nokogiri (1.11.3-java)
racc (~> 1.4)
nokogiri (1.11.1-x64-mingw32)
nokogiri (1.11.3-x64-mingw32)
racc (~> 1.4)
nokogiri (1.11.1-x86-mingw32)
nokogiri (1.11.3-x86-mingw32)
racc (~> 1.4)
nokogiri (1.11.1-x86_64-darwin)
nokogiri (1.11.3-x86_64-darwin)
racc (~> 1.4)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these other architectures were removed 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is expected behavior since nokogiri gem is now precompiled native gem since 1.11.0. Refer sparklemotion/nokogiri#2075 and sparklemotion/nokogiri#2185 From Rails side, what we can do now is waiting for a new version of nokogiri gem after Ruby 3.1.0 is released.

Also, Rails CI actually removes Gemfile.lock then bundle install .

https://github.com/rails/buildkite-config/blob/8b7d116453fa6fcf3075e8a685686ac5b69e2fcb/Dockerfile#L133

    && rm Gemfile.lock && bundle install -j 8 && cp Gemfile.lock tmp/Gemfile.lock.updated \

So, unless we need to bump gem version at Gemfile itself, we do not need to update Gemfile.lock to support Ruby 3.1.0-dev.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yahonda Hello!

this is expected behavior since nokogiri gem is now precompiled native gem since 1.11.0. Refer sparklemotion/nokogiri#2075 and sparklemotion/nokogiri#2185

I understand that the behavior of nokogiri is to install the precompiled gem for my architecture, but I'm wondering why just bumping from 1.11.1 to 1.11.3 would remove the other architectures from the lock file. Maybe its my version of bundler from ruby HEAD?

It also seems that only this version on x86_64-darwin is affected.

Would it be a big deal to just merge these versions which are working locally? I assume they don't break for existing Ruby versions, but the alternative is having to maintain a dirty Gemfile.lock in my local checkout in order to hack on Rails 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a Bundler issue: rubygems/rubygems#4516

os (1.1.1)
parallel (1.20.1)
Expand Down