Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-define _routes when not set correctly via inheritance #41463

Merged
merged 2 commits into from Feb 16, 2021
Merged

Re-define _routes when not set correctly via inheritance #41463

merged 2 commits into from Feb 16, 2021

Commits on Feb 16, 2021

  1. Force _routes to be redefined on re-inclusion 

    This fixes an regression where _routes were set incorrectly when the
inheritance chain went from one route namespace (isolated engine or main
app) to another and then back to the original. Because the url_helpers
module was being cached and was being re-included this was not setting
_routes.

This commit solves the issue by detecting that case and redefining
_routes in that case. We could have always performed the redefinition,
but it's a pretty uncommon case, so we might as well only do it when
necessary.
    @jhawthorn
    jhawthorn committed Feb 16, 2021
    Copy the full SHA
    d6ca733 View commit details
    Browse the repository at this point in the history

  2. test case to illustrate isolated engine inheritance issue

    @inopinatus @jhawthorn
    inopinatus authored and jhawthorn committed Feb 16, 2021
    Copy the full SHA
    715d6bc View commit details
    Browse the repository at this point in the history