Avoid stack level too deep in predicate builder

[afrase]

Summary

If you have an association with the same name as the foreign key then a SystemStackError: stack level too deep error is raised.

This PR addresses the issue by checking if the query variable is different from attributes argument before recursively calling expand_from_hash. We have been running this fix in production for a number of years without issue at the company I work for.

This issue has been mentioned in a number of issues #26778, #34869, #31110.

Other Information

Something to note is the setter for the association can raise errors. I have another branch that fixes that but I'm not sure if using an association extension is the best way to handle it.

Thanks

[afrase]

Closing in favor of #41394