Commits on Jan 24, 2021

1. Handle throwing in controller action in log subscriber …

   When throw was used in a controller action, and there is matching catch
   around the request in a Rack middleware, then :exception won't be
   present in the event payload.
   
   This is because ActiveSupport::Notifications::Instrumenter.instrument
   sets :exception in a rescue handler, but rescue is never called in a
   throw/catch scenario:
   
     catch(:halt) do
       begin
         throw :halt
       rescue Exception => e
         puts "rescue" # never reached
       ensure
         puts "ensure"
       end
     end
   
   Missing :exception was actually handled prior to Rails 6.1.0, but an
   optimization updated the code to assume this was present. So this can be
   considered a regression fix.

   

   janko committed Jan 24, 2021
   Copy the full SHA

   53adf53 View commit details

   Browse the repository at this point in the history