Deprecate assigning single trusted_proxies value
#40789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csutter
force-pushed
the
deprecate-remote-ip-single-value
branch
from
9f2f088
to
5e4314a
Compare
|
Got the original issue number wrong in the commit message and changelog, whoops! 😅 Re-pushed. |
csutter
force-pushed
the
deprecate-remote-ip-single-value
branch
2 times, most recently
from
b853b02
to
a1b1009
Compare
Fixes rails#40772 The `RemoteIp` middleware currently behaves inconsistently depending on whether `config.action_dispatch.trusted_proxies` is configured with a single value or an enumerable. - Deprecate ability to assign a single value to `trusted_proxies` in `RemoteIp` middleware - Add an explicit test for the setting overriding the default list of trusted proxies
csutter
force-pushed
the
deprecate-remote-ip-single-value
branch
from
a1b1009
to
bdd49dc
Compare
csutter
added a commit
to csutter/rails
that referenced
this pull request
Mar 26, 2021
The way this test initializes `ActionDispatch::RemoteIp` has been deprecated in rails#40789. This makes the test append to the existing trusted proxy list instead of assigning a single value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #40772
trusted_proxiesinRemoteIpmiddlewareThe
RemoteIpmiddleware currently behaves inconsistently depending on whetherconfig.action_dispatch.trusted_proxiesis configured with a single value or an enumerable. This is surprising behaviour and can lead to frustration when e.g. moving from having one single trusted proxy specified to needing multiple (and vice versa).For example, the following two settings behave differently: