Handle nil translation key #40788
Merged
Handle nil translation key #40788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`I18n.translate` returns `nil` when given a `nil` key, *unless* a `default` is also specified. If a `default` is specified, the `nil` key is treated as a missing key. In Rails 6.0, the `translate` helper always returned `nil` when given a `nil` key. After rails#40773, the `translate` helper always raised an `I18n::ArgumentError` when given a `nil` key. This commit fixes the `translate` helper to mirror the `I18n.translate` behavior when given a `nil` key, with and without a `default`.
jonathanhefner
force-pushed
the
translate-nil-key
branch
from
673ab8b
to
b8b18bb
Compare
rafaelfranca
added a commit
that referenced
this pull request
Dec 16, 2020
Handle nil translation key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n.translatereturnsnilwhen given anilkey, unless adefaultis also specified. If adefaultis specified, thenilkey is treated as a missing key.In Rails 6.0, the
translatehelper always returnednilwhen given anilkey. After #40773, thetranslatehelper always raised anI18n::ArgumentErrorwhen given anilkey. This commit fixes thetranslatehelper to mirror theI18n.translatebehavior when given anilkey, with and without adefault.Fixes #40773 (comment).
Since this changes the behavior of the
translatehelper when both anilkey and adefaultare specified, I've added a CHANGELOG entry. If we do not want to change this for 6.1.1, I can create a separate PR against6-1-stablethat restores the Rails 6.0 behavior fornilkeys.