Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow_nil should work for casted value in NumericalityValidator #40765

Merged
merged 2 commits into from Dec 9, 2020
Merged

allow_nil should work for casted value in NumericalityValidator #40765

merged 2 commits into from Dec 9, 2020

Commits on Dec 8, 2020

  1. allow_nil should work for casted value in NumericalityValidator 

    It is a regression for 4cc438a.

`NumericalityValidator` basically takes the value before typecasting,
but `allow_nil` should work for the typecasted value for the
compatibility.

Fixes rails#40750.
    @kamipo
    kamipo committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    1dee499 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Split the options checks from read_attribute_for_validation

    @kamipo
    kamipo committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    720a60e View commit details
    Browse the repository at this point in the history