Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HTTP Feature Policy to Permissions Policy #40620

Merged
merged 1 commit into from Nov 18, 2020

Conversation

Bahanix
Copy link
Contributor

@Bahanix Bahanix commented Nov 14, 2020

HTTP Feature-Policy has been renamed to Permissions-Policy:

According to archive.org, Mozilla documentation has been updated July 14th, 2020:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy

This PR ports this renaming into Rails.

cc. @jacobbednarz who authored the feature.

Copy link
Contributor

@DNNX DNNX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by typo fixes.

@fxn fxn merged commit 26fd55e into rails:master Nov 18, 2020
@fxn
Copy link
Member

fxn commented Nov 18, 2020

Thanks! ❤️

@p8
Copy link
Member

p8 commented Nov 19, 2020

@Bahanix The permissions-policy also changed the format of the data to a structured header:
w3c/webappsec-permissions-policy#383

So the following:

 "usb 'self'; autoplay https://example.com; payment https://secure.example.com" 

Would need to change to

   "usb=(self), autoplay=(https://example.com), payment=(https://secure.example.com)" 

@Bahanix Bahanix deleted the permissions-policy branch November 19, 2020 14:48
@p8
Copy link
Member

p8 commented Nov 19, 2020

I've created a PR to use the old name for the header for now. #40652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants