Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack responses may be frozen #40598

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 18 additions & 1 deletion actionpack/lib/action_dispatch/middleware/request_id.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,24 @@ def initialize(app, header:)
def call(env)
req = ActionDispatch::Request.new env
req.request_id = make_request_id(req.headers[@header])
@app.call(env).tap { |_status, headers, _body| headers[@header] = req.request_id }

response = @app.call(env)

status, headers, body = response

if headers.frozen?
headers = headers.dup

if response.frozen?
response = [status, headers, body]
else
response[1] = headers
end
end

headers[@header] = req.request_id

response
end

private
Expand Down