Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update w3c_validtors for Ruby 3 compatibility #40227

Merged
merged 2 commits into from Sep 21, 2020
Merged

Update w3c_validtors for Ruby 3 compatibility #40227

merged 2 commits into from Sep 21, 2020

Conversation

utilum
Copy link
Contributor

@utilum utilum commented Sep 14, 2020

This leaves us waiting for google-api-client and listen to be released

googleapis/google-api-ruby-client#907
guard/listen#490

And for redis-namespace fix and release

resque/redis-namespace#175

@eugeneius
Copy link
Member

It looks like we're still waiting on w3c-validators/w3c_validators#48.

@utilum
Copy link
Contributor Author

utilum commented Sep 16, 2020

Right!
Sorry, I missed that. When I patch the other gem versions locally and bundle install w3c_validators reverts to v. 1.2 which does not require a Ruby version.

Shall I close this for now?

@kamipo
Copy link
Member

kamipo commented Sep 20, 2020

Can you update the w3c_validators version to 1.3.6?

https://rubygems.org/gems/w3c_validators
https://github.com/w3c-validators/w3c_validators/releases/tag/1.3.6

That version includes w3c-validators/w3c_validators#48.

@utilum utilum force-pushed the update_w3c_validators_to_ruby3_compat branch from b1b2f0f to 06b6b02 Compare September 20, 2020 18:25
@utilum
Copy link
Contributor Author

utilum commented Sep 20, 2020

Done. Thank you.
google-api-client 0.44.2 has been released in the mean time, also fixes this issue. Shall I add it here? Open a separate pull?
Either way, this would leave us waiting for listen and redis-namespace.

@kamipo
Copy link
Member

kamipo commented Sep 21, 2020

If google-api-client is released, please include it in this PR, then I'll (squash) merge (like 858e429).

Personally I don't think it's worth updating one by one commits, it will not be buildable in Ruby 3 until all gems have been updated.

@utilum utilum force-pushed the update_w3c_validators_to_ruby3_compat branch from 06b6b02 to f67d2bf Compare September 21, 2020 04:45
@utilum
Copy link
Contributor Author

utilum commented Sep 21, 2020

Done.
But I see your point. Perhaps better to leave this open as a WIP and only merge when all gems have been updated?
Or close and ditto?

@kamipo
Copy link
Member

kamipo commented Sep 21, 2020

I'll merge this anyway since listen and redis-namespace are less frequently released.

https://rubygems.org/gems/listen
https://rubygems.org/gems/redis-namespace

@kamipo kamipo merged commit 1541e5b into rails:master Sep 21, 2020
@utilum utilum deleted the update_w3c_validators_to_ruby3_compat branch September 21, 2020 05:27
kamipo added a commit that referenced this pull request Dec 27, 2020
@utilum @kamipo
Update w3c_validtors for Ruby 3 compatibility (#40227)
924cbe6 
* Update w3c_validtors for Ruby 3 compatibility

* Update google-api-client for Ruby 3 compatibility

Co-authored-by: Ryuta Kamizono <kamipo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@utilum @eugeneius @kamipo