AD::Static refactor with precompressed Brotli support #38674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
changed the title
jeremy
force-pushed
the
brotli
branch
2 times, most recently
from
2754567
to
eab53cc
Compare
rafaelfranca
approved these changes
Mar 12, 2020
bdewater
reviewed
Apr 20, 2020
|
@jeremy Is there anything more needed to get this PR merged? It is still marked as draft. |
When using an external build process (webpack, grunt) it's helpful for rails to be able to serve those assets. Brotli has better compression than gzip and should eventually replace it for static assets. When using an external build process (webpack, grunt) it's helpful for rails to be able to serve those assets. Brotli has better compression than gzip and will eventually replace it for static assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on code in #29753. Refactoring to clarify the relationship between Static (middleware that tries to serve and falls back to app), FileHandler (endpoint that mediates some content negotiation), and Rack::File (endpoint that serves negotiated file content), and to accommodate encoding negotiation.