fix add_controller_module': undefined method start_with?' for :bloc…
#37657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks:Symbol (NoMethodError) controller can be string or symbol
|
Is it possible to add a test the exercises this logic that would have failed without this patch? To see what other tests hit that code try adding a raise and running the test suite, it will show you what tests exercise that logic. |
eugeneius
reviewed
Nov 8, 2019
| @@ -355,7 +355,7 @@ def split_to(to) | |||
|
|
|||
| def add_controller_module(controller, modyoule) | |||
| if modyoule && !controller.is_a?(Regexp) | |||
| if controller && controller.start_with?("/") | |||
| if %r{\A/}.match?(controller) | |||
There was a problem hiding this comment.
This will reintroduce the deprecation warning fixed in #37504.
We need to avoid the comparison when controller is nil:
Suggested change
| if %r{\A/}.match?(controller) | |
| if controller && %r{\A/}.match?(controller) |
|
I think @rafaelfranca fixed it in 63256bc |
|
Yes, this is fixed on master. Thanks for the patch 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
add_controller_module': undefined methodstart_with?' for :blocks:Symbol (NoMethodError)