Update rails-html-sanitizer to 1.1.0 in actionview.gemspec #36860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit rails@52f0b05 replaces `white_list_sanitizer` with `safe_list_sanitizer`. This is a breaking change unless the installed version of `rails-html-sanitizer` is `>= 1.1.0`. This commit updates the minimum version in `actionview/actionview.gemspec` to `1.1.0`.
eileencodes
added a commit
that referenced
this pull request
Aug 5, 2019
…tizer-version Update rails-html-sanitizer to 1.1.0 in actionview.gemspec
|
I see that 52f0b05 was backported to |
eileencodes
added a commit
to eileencodes/rails
that referenced
this pull request
Aug 6, 2019
The PR rails#36860 changed ActionView's required version of rails-html-sanitizer, but I missed that we needed to run bundle, otherwise we end up with changes every time.
Merged
eileencodes
added a commit
that referenced
this pull request
Aug 6, 2019
The PR #36860 changed ActionView's required version of rails-html-sanitizer, but I missed that we needed to run bundle, otherwise we end up with changes every time.
|
Sorry, I didn't get back to you @bogdanvlviv, here's the latest: #36858 (comment) 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 52f0b05 replaces
white_list_sanitizerwithsafe_list_sanitizer. At GitHub we found this to be a breaking change with Rails 6.0 unless the version ofrails-html-sanitizeris upgraded to>= 1.1.0.This PR updates the minimum version of
rails-html-sanitizerinactionview/actionview.gemspecto1.1.0.CC: @JuanitoFatas, @kaspth, @eileencodes