Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve user supplied joins order as much as possible #36805

Merged
merged 1 commit into from Jul 30, 2019
Merged

Preserve user supplied joins order as much as possible #36805

merged 1 commit into from Jul 30, 2019

Commits on Jul 29, 2019

  1. Preserve user supplied joins order as much as possible 

    Currently, string joins are always applied as last joins part, and Arel
join nodes are always applied as leading joins part (since rails#36304), it
makes people struggled to preserve user supplied joins order.

To mitigate this problem, preserve the order of string joins and Arel
join nodes either before or after of association joins.

Fixes rails#36761.
Fixes rails#34328.
Fixes rails#24281.
Fixes rails#12953.
    @kamipo
    kamipo committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    b4478ae View commit details
    Browse the repository at this point in the history