Commits on Jun 2, 2019

1. Remove spring-watcher-listen from default Gemfile …

   `spring-watcher-listen` watch application root by default.
   https://github.com/jonleighton/spring-watcher-listen/blob/c4bfe15805867e229588e4b776a7b87438137094/lib/spring/watcher/listen.rb#L58
   
   This is necessary to watch the file (e.g. `.ruby-version`) in the
   application root.
   
   By this `node_modules` also be watched, and it is a possibility to be
   shown a warning by `listen`.
   Related to rails#32700, rails#34912, rails/webpacker#1990.
   
   `listen` watches directory recursive by default, and it cannot avoid it.
   guard/listen#111
   
   So If this warning happens, the only workaround the user can do is remove
   the gem.
   
   The issue is likely to occur more frequently in Rails 6 because
   `rails new` runs `webpacker:install` by default. Because of such a
   state, I think that we should not recommend to use
   `spring-watcher-listen`.
   
   Spring has polling watcher, restart process works without this
   `spring-watcher-listen`.
   Because of polling base, CPU load may be higher than listen base. Still
   I think that it is better than the warning comes out.

   

   y-yagi committed Jun 2, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 1ff98ed
   • Browse repository at this point

   Copy the full SHA

   1ff98ed View commit details

   Browse the repository at this point in the history