Bump RuboCop to 0.68.1 #36176
Closed
Bump RuboCop to 0.68.1 #36176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance cops were extracted in rubocop/rubocop#5977 and @koic updated to 0.67.2 and added the rubocop-performance gem in rails#35989. This bumps rubocop to 0.68.1 to be on the latest version. Two changes were made in regards to the bump of the version: * The first was that Layout/FirstParameterIndentation was renamed to Layout/IndentFirstArgument. These changes can be seen in rubocop/rubocop#6982 and rubocop/rubocop#6987 * The second was that a new instance of the Style/HashSyntax cop was found. I updated that instance to follow the new Ruby >= 1.9 syntax.
|
Thanks for your PR. Please try to update the CodeClimate side first. Thanks. |
|
Working on it here: codeclimate/codeclimate-rubocop#168 |
|
FYI, please bump RuboCop Performance to 1.2.0 to apply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance cops were extracted in rubocop/rubocop#5977 and @koic
updated to 0.67.2 and added the rubocop-performance gem in #35989.
This bumps rubocop to 0.68.1 to be on the latest version. Two changes
were made in regards to the bump of the version:
Layout/IndentFirstArgument. These changes can be seen in
Add IndentFirstArgument and IndentFirstParameter rubocop/rubocop#6982 and Add obsolete message for renaming
Layout/FirstParameterIndentationrubocop/rubocop#6987found. I updated that instance to follow the new Ruby >= 1.9 syntax.