Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog to explain the fix of #35114 [ci skip] #36040

Merged
merged 1 commit into from Apr 22, 2019
Merged

Update changelog to explain the fix of #35114 [ci skip] #36040

merged 1 commit into from Apr 22, 2019

Conversation

st0012
Copy link
Contributor

@st0012 st0012 commented Apr 19, 2019 •
edited by eileencodes

Update changelog about #35114 's fix

@rails-bot rails-bot bot added the actionview label Apr 19, 2019
@st0012
Copy link
Contributor Author

st0012 commented Apr 20, 2019

cc @matthewd

@st0012
Copy link
Contributor Author

st0012 commented Apr 20, 2019

@sikachu thank you!

@eileencodes
Copy link
Member

Updated your comment to be the correct PR because I was really confused at first 😅

@eileencodes eileencodes merged commit 759c8d5 into rails:master Apr 22, 2019
@st0012
Copy link
Contributor Author

st0012 commented Apr 22, 2019

@eileencodes ah sorry 😅 thanks for merging

@st0012 st0012 deleted the update-changelog-for-35145 branch April 22, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikachu sikachu sikachu approved these changes

Assignees
No one assigned
Labels
actionview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@st0012 @eileencodes @sikachu