Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fix server restart test #35696

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Backport fix server restart test #35696

merged 1 commit into from
Mar 22, 2019

Commits on Mar 22, 2019

  1. Fix server restart test on Puma 3.12.1 

    Since puma/puma#1700, the default host is
correctly used. So `localhost` is used instead of `0.0.0.0`.

As a result, the log output on restart is changed, and the restart test
fails on Puma 3.12.1.
https://travis-ci.org/rails/rails/jobs/509239592#L2303-L2305

Specify binding explicitly to avoid being affected by Puma changes.
    @y-yagi
    y-yagi committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    1008a0c View commit details
    Browse the repository at this point in the history