Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ajv@6.9.0 for now #35211

Merged
merged 1 commit into from Feb 10, 2019
Merged

Avoid ajv@6.9.0 for now #35211

merged 1 commit into from Feb 10, 2019

Conversation

y-yagi
Copy link
Member

@y-yagi y-yagi commented Feb 10, 2019

Because ajv@6.9.0 does not work with webpack.
Ref: ajv-validator/ajv#941

@rails-bot rails-bot bot added the railties label Feb 10, 2019
@y-yagi
Avoid ajv@6.9.0 for now
7942d67 
Because ajv@6.9.0 does not work with webpack.
Ref: ajv-validator/ajv#941
@y-yagi y-yagi merged commit 38f9e41 into rails:master Feb 10, 2019
@y-yagi y-yagi deleted the fix_broken_association_test branch February 10, 2019 07:23
y-yagi added a commit to y-yagi/rails that referenced this pull request Feb 10, 2019
@y-yagi
Revert "Merge pull request rails#35211 from y-yagi/fix_broken_associa…
6823f72 
…tion_test"

This reverts commit 38f9e41, reversing
changes made to 5e493c3.

Reason: The ajv@6.9.1 was released that fixes issue.
y-yagi added a commit that referenced this pull request Feb 11, 2019
@y-yagi
Revert "Merge pull request #35211 from y-yagi/fix_broken_association_…
9099d66 
…test" (#35217)

This reverts commit 38f9e41, reversing
changes made to 5e493c3.

Reason: The ajv@6.9.1 was released that fixes issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@y-yagi