Add a test with extra keys to active_storage Service#upload #34576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Nov 30, 2018
Add a test with extra keys to active_storage Service#upload
y-yagi
added a commit
that referenced
this pull request
Dec 1, 2018
y-yagi
added a commit
that referenced
this pull request
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
S3Service#uploadwas broken in5.2.1.1and got fixed in #34550This adds a shared test ensuring that the
uploadmethod accepts the extra hash for all the services.This takes the keys present in the documentation around
attachments.attach