Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the scoping with query methods in the scope block #34572

Merged
merged 1 commit into from Nov 30, 2018
Merged

Fix the scoping with query methods in the scope block #34572

merged 1 commit into from Nov 30, 2018

Commits on Nov 29, 2018

  1. Fix the scoping with query methods in the scope block 

    Follow up rails#33394.

rails#33394 only fixes the case of scoping with klass methods in the scope
block which invokes `klass.all`.
Query methods in the scope block also need to invoke `klass.all` to be
affected by the scoping.
    @kamipo
    kamipo committed Nov 29, 2018
    Copy the full SHA
    3090b35 View commit details
    Browse the repository at this point in the history