Fix as attribute value for preload link
#31838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`as` attribute value should be `style` for stylesheet preload link See https://w3c.github.io/preload/#as-attribute
|
Yes please backport to 5-2-stable. |
bogdanvlviv
deleted the
fix-value-of-as-attribute-for-link-type-preload
branch
bogdanvlviv
pushed a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 31, 2018
…bute-for-link-type-preload Fix `as` attribute value for preload link [Eileen M. Uchitelle & bogdanvlviv]
eileencodes
added a commit
that referenced
this pull request
Jan 31, 2018
Backport #31838 to 5-2-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asattribute value should bestylefor stylesheet preload linkSee https://w3c.github.io/preload/#as-attribute
#30744 (comment) thanks for the report @mengqing
shall I backport it to
5-2-stable?r? @eileencodes