Railties updates for frozen string literals.

[pat]

Updates to railties for frozen-string-literals compatibility.

It's worth noting that there are dependencies on the following libraries that aren't yet compatible:

• rack
• thor
• method_source
• puma
• sass

When the above patches are in play, then the tests pass with RUBYOPT="--enable-frozen-string-literal".

/cc @kirs given you're doing a lot of this work too!

[rails-bot]

r? @schneems

(@rails-bot has picked a reviewer for you, use r? to override)

[pat]

Also, @kirs: is this the last piece of the Rails puzzle that needs the pragma comment? Or are there other parts of Rails that still need some attention?

[kirs]

Great work!
Enabled parts are activesupport, activemodel, activejob, activerecord. I'm working on actioncable, and then there'll be actionmailer (#29896), actionpack (#29933), and actionview (#29897) left. Not counting railties that you're working on.

[kirs]

Can you add the frozen string literals to the changed files?
At least that's what @matthewd asked me for similar fixes in https://github.com/rails/rails/pull/29655/files#diff-53e65e5b02bb6a167c2270e40aa780fdL1

[koic]

Hi @pat. Thanks for great work. It is a note related to this PR.

After rebasing with the latest master branch, you can remove 'railties/**/*' from Exclude of Style/FrozenStringLiteralComment in .rubocop.yml.

 Style/FrozenStringLiteralComment:
   Enabled: true
   EnforcedStyle: always
   Include:
   Exclude:
-    - 'railties/**/*'
     - 'actionview/test/**/*.builder'
     - 'actionview/test/**/*.ruby'
     - 'actionpack/test/**/*.builder'
     - 'actionpack/test/**/*.ruby'

Please look when adding frozen string literal magic comments.

[kirs]

Looks like Railties is the last component that's left to complete the migration to frozen string literal 💯

[pat]

Thanks @koic, @kirs. Latest commits I've just pushed include:

• my original changes
• all the pragma comments
• the removal of the corresponding Rubocop exception
• Some test tweaks now that the pragma comments are in place.

Let me know if you need anything further from me to get this merged in :)

[kirs]

LGTM ❤️

[pat]

Thanks @rafaelfranca!