Fix 6.1 compatability with ruby 2.5 #45593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.5 ships with Psych 3.0.x, which doesn't include keyword params for permitted_classes.
This was missed in fbb7f0b
skipkayhil
changed the title
eileencodes
added a commit
that referenced
this pull request
Jul 15, 2022
Fix 6.1 compatability with ruby 2.5
eileencodes
added a commit
that referenced
this pull request
Jul 15, 2022
Fix 6.1 compatability with ruby 2.5
|
I backported this to 6-0-stable and 5-2-stable. Both required backports of other changes. For anyone who ends up here, I'm not sure when we're going to do bugfix releases but it's highly unlikely 5-2-stable will get one. It's been EOL since June, this was the last security release of 5.2. If you need these changes, please point your gemfile at the 5-2-stable branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ruby 2.5 ships with Psych 3.0.x, which doesn't include keyword params
for permitted_classes.
Other Information
respond_to?check, but the code complexity will really start to balloon6-0-stableor5-2-stableunless Improve performance by removing respond_to? from runtime code #45578 is backported to those as well. I can make a new PR for the older branches if desiredFixes #45590