Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveRecord 5.2.8.1 uses incorrect parameters for YAML.safe_load, thereby requiring ruby 2.6 #47362

Closed
matthewhively opened this issue Feb 11, 2023 · 1 comment

Comments

@matthewhively
Copy link

The implementation of ActiveRecord::Coders::YAMLColumn.yaml_load in rails 5.2.8.1 currently follows the parameter definition in the ruby 2.6 function definition.

The method was introduced by this commit:
6576aa7 (july 12th 2022)

It looks like the issue was resolved by this commit:
5ab06e5 (july 13th 2022)
but was not included in rails 5.2.8.1 (released Nov 23, 2022) so therefore the required ruby version has effectively become 2.6 instead of 2.2.2 as listed in the gemspec.

System configuration

Rails version: 5.2.8.1

Ruby version: 2.5.7

@zzak
Copy link
Member

zzak commented Feb 12, 2023

Looks like there is context here:
#45593 (comment)

Since this version is EOL, it's unlikely to receive a bugfix release, but that decision is beyond me.

It's suggested to point your Gemfile at the 5-2-stable branch, are you able to use that?

Because there is a workaround and this version is unsupported, I think we can close this ticket.

@zzak zzak closed this as completed Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants