Fix Range#overlaps? for beginless ranges
#44757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `#first` raises an error when called on a beginless range. Using `#begin` to get the first element instead. - Adding additional equality condition to cover the case when both ranges are beginless
Another solution can be to swap def overlaps?(other)
cover?(other.begin || -Float::INFINITY) || other.cover?(self.begin)
endNot sure which one is better |
rafaelfranca
pushed a commit
that referenced
this pull request
Mar 23, 2022
Fix `Range#overlaps?` for beginless ranges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue #44755
Using
Range#beginto get the first element of the range.Range#firstraises an error when called on a beginless range.Adding additional equality condition to cover the case when both ranges are beginless.