Do not use submit_tag auto-disabling when disable_with is set to false #40168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If automatically_disable_submit_tag is set to false then disable_with is ignored, as result in all cases where disable_with is explicitly set to false will produce unexpected result
KapilSachdev
reviewed
Sep 3, 2020
| @@ -897,16 +897,15 @@ def sanitize_to_id(name) | |||
| end | |||
|
|
|||
| def set_default_disable_with(value, tag_options) | |||
| return unless ActionView::Base.automatically_disable_submit_tag | |||
| data = tag_options["data"] | |||
There was a problem hiding this comment.
Suggested change
| data = tag_options["data"] | |
| data = tag_options.fetch("data", {}) |
This will save us from checking data && data["disable_with"] == false and also data.delete("disable_with") if data and disable_with_text ||= data["disable_with"] if data.
There was a problem hiding this comment.
@KapilSachdev this broke our app. We have places where we're passing data: nil:
- data = { confirm: "sure?" } if doc.confirm?
= f.submit 'Update choice', data: data
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
rafaelfranca
added a commit
that referenced
this pull request
Dec 9, 2020
…disable_submit_tag Do not use submit_tag auto-disabling when disable_with is set to false
rafaelfranca
added a commit
that referenced
this pull request
Dec 9, 2020
…disable_submit_tag Do not use submit_tag auto-disabling when disable_with is set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If we have
data: { disable_with: false }then auto-disabling is turned off, but if we setautomatically_disable_submit_tagtofalseit changes the behaviour ofdisable_within an unexpected way, so explicit usage ofdisalbe_with: falsestarts to enable auto-disabling withfalseas the value of a disabled button.It looks like a more convenient way to have auto-disabling turned off if we have explicit
disalbe_with: falseno matter what is set inautomatically_disable_submit_tag