Merge pull request #40168 from igor04/disable_with_and_automatically_…

…disable_submit_tag Do not use submit_tag auto-disabling when disable_with is set to false
rails · Dec 9, 2020 · e0a362c · e0a362c
2 parents d3ccc92 + a0fe1e7
commit e0a362c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/actionview/lib/action_view/helpers/form_tag_helper.rb b/actionview/lib/action_view/helpers/form_tag_helper.rb
@@ -934,16 +934,15 @@ def sanitize_to_id(name)
         end
 
         def set_default_disable_with(value, tag_options)
-          return unless ActionView::Base.automatically_disable_submit_tag
           data = tag_options["data"]
 
-          unless tag_options["data-disable-with"] == false || (data && data["disable_with"] == false)
+          if tag_options["data-disable-with"] == false || (data && data["disable_with"] == false)
+            data.delete("disable_with") if data
+          elsif ActionView::Base.automatically_disable_submit_tag
             disable_with_text = tag_options["data-disable-with"]
             disable_with_text ||= data["disable_with"] if data
             disable_with_text ||= value.to_s.clone
             tag_options.deep_merge!("data" => { "disable_with" => disable_with_text })
-          else
-            data.delete("disable_with") if data
           end
 
           tag_options.delete("data-disable-with")

diff --git a/actionview/test/template/form_tag_helper_test.rb b/actionview/test/template/form_tag_helper_test.rb
@@ -562,6 +562,16 @@ def test_empty_submit_tag_with_opt_out
     ActionView::Base.automatically_disable_submit_tag = true
   end
 
+  def test_empty_submit_tag_with_opt_out_and_explicit_disabling
+    ActionView::Base.automatically_disable_submit_tag = false
+    assert_dom_equal(
+      %(<input name='commit' type="submit" value="Save" />),
+      submit_tag("Save", data: { disable_with: false })
+    )
+  ensure
+    ActionView::Base.automatically_disable_submit_tag = true
+  end
+
   def test_submit_tag_having_data_disable_with_string
     assert_dom_equal(
       %(<input data-disable-with="Processing..." data-confirm="Are you sure?" name='commit' type="submit" value="Save" />),