Skip to content

Commit

Permalink
Merge pull request #41436 from santib/fix-active-storage-sharpening-docs
Browse files Browse the repository at this point in the history
Fix Upgrading guides [ci skip]
  • Loading branch information
jonathanhefner committed Feb 15, 2021
2 parents 96106d8 + 7f7ed5e commit be7185b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion guides/source/upgrading_ruby_on_rails.md
Expand Up @@ -235,7 +235,7 @@ The default HTTP status code used in `ActionDispatch::SSL` when redirecting non-

When processing variants in Active Storage, it's now required to have the [image_processing gem](https://github.com/janko-m/image_processing) bundled instead of directly using `mini_magick`. Image Processing is configured by default to use `mini_magick` behind the scenes, so the easiest way to upgrade is by replacing the `mini_magick` gem for the `image_processing` gem and making sure to remove the explicit usage of `combine_options` since it's no longer needed.

That said, it's recommended to change the calls to raw `resize` for `image_processing` macros as they also sharpen the thumbnail after resizing. For example, instead of:
For readability, you may wish to change raw `resize` calls to `image_processing` macros. For example, instead of:

```ruby
video.preview(resize: "100x100")
Expand Down

0 comments on commit be7185b

Please sign in to comment.