Merge pull request #34550 from mogulla3/fix-argument-error-when-uplod…

…ing-to-s3 Fix `ArgumentError` when uploading to amazon s3
rails · Nov 28, 2018 · a69b5b1 · a69b5b1
1 parent 44fc938
commit a69b5b1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/activestorage/CHANGELOG.md b/activestorage/CHANGELOG.md
@@ -1,3 +1,7 @@
+*   Fix `ArgumentError` when uploading to amazon s3
+
+    *Hiroki Sanpei*
+
 ## Rails 5.2.1.1 (November 27, 2018) ##
 
 *   Prevent content type and disposition bypass in storage service URLs.

diff --git a/activestorage/lib/active_storage/service/s3_service.rb b/activestorage/lib/active_storage/service/s3_service.rb
@@ -16,7 +16,7 @@ def initialize(bucket:, upload: {}, **options)
       @upload_options = upload
     end
 
-    def upload(key, io, checksum: nil)
+    def upload(key, io, checksum: nil, **)
       instrument :upload, key: key, checksum: checksum do
         begin
           object_for(key).put(upload_options.merge(body: io, content_md5: checksum))