Skip to content

Commit

Permalink
test case to illustrate isolated engine inheritance issue
Browse files Browse the repository at this point in the history
  • Loading branch information
inopinatus authored and jhawthorn committed Feb 16, 2021
1 parent d6ca733 commit 715d6bc
Showing 1 changed file with 28 additions and 1 deletion.
29 changes: 28 additions & 1 deletion railties/test/railties/engine_test.rb
Expand Up @@ -644,7 +644,7 @@ class Engine < ::Rails::Engine
assert_equal Rails.application.routes, env["action_dispatch.routes"]
end

test "isolated engine should include only its own routes and helpers" do
test "isolated engine routes and helpers are isolated to that engine" do
@plugin.write "lib/bukkits.rb", <<-RUBY
module Bukkits
class Engine < ::Rails::Engine
Expand Down Expand Up @@ -729,6 +729,30 @@ def polymorphic_path_without_namespace
end
RUBY

@plugin.write "app/controllers/bukkits/session_controller.rb", <<-RUBY
module Bukkits
class SessionController < ApplicationController
def index
render plain: default_path
end
private
def default_path
foo_path
end
end
end
RUBY

controller "bar", <<-RUBY
class BarController < Bukkits::SessionController
private
def default_path
bar_path
end
end
RUBY

@plugin.write "app/mailers/bukkits/my_mailer.rb", <<-RUBY
module Bukkits
class MyMailer < ActionMailer::Base
Expand All @@ -746,6 +770,9 @@ class MyMailer < ActionMailer::Base
assert ::Bukkits::MyMailer.method_defined?(:foo_url)
assert_not ::Bukkits::MyMailer.method_defined?(:bar_url)

get("/bar")
assert_equal "/bar", last_response.body

get("/bukkits/from_app")
assert_equal "false", last_response.body

Expand Down

0 comments on commit 715d6bc

Please sign in to comment.