Merge pull request #36762 from Shopify/descendants-tracker-cleanup

Optimize DescendantsArray insertions
rails · Jul 25, 2019 · 53d9bb9 · 53d9bb9
2 parents 1d83ab9 + 62a1d7e
commit 53d9bb9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/activesupport/lib/active_support/descendants_tracker.rb b/activesupport/lib/active_support/descendants_tracker.rb
@@ -77,15 +77,17 @@ def initialize_copy(orig)
       end
 
       def <<(klass)
-        cleanup!
         @refs << WeakRef.new(klass)
       end
 
       def each
-        @refs.each do |ref|
+        @refs.reject! do |ref|
           yield ref.__getobj__
+          false
         rescue WeakRef::RefError
+          true
         end
+        self
       end
 
       def refs_size