Skip to content

Commit

Permalink
Merge pull request #44712 from Shopify/fix-mysql-show-create-table
Browse files Browse the repository at this point in the history
Get rid of `MySQL::SchemaStatements#create_table_sql`
  • Loading branch information
tenderlove authored and rafaelfranca committed Mar 17, 2022
1 parent c730f80 commit 365a85c
Showing 1 changed file with 1 addition and 7 deletions.
Expand Up @@ -159,7 +159,7 @@ def create_table_definition(name, **options)
end

def default_type(table_name, field_name)
match = create_table_sql(table_name).match(/`#{field_name}` (.+) DEFAULT ('|\d+|[A-z]+)/)
match = create_table_info(table_name).match(/`#{field_name}` (.+) DEFAULT ('|\d+|[A-z]+)/)
default_pre = match[2] if match

if default_pre == "'"
Expand All @@ -171,12 +171,6 @@ def default_type(table_name, field_name)
end
end

def create_table_sql(table_name)
execute_and_free("SHOW CREATE TABLE #{quote_table_name(table_name)}") do |result|
result.first[1]
end
end

def new_column_from_field(table_name, field)
field_name = field.fetch(:Field)
type_metadata = fetch_type_metadata(field[:Type], field[:Extra])
Expand Down

0 comments on commit 365a85c

Please sign in to comment.