Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nokogiri -v to .travis.yml #61

Closed

Conversation

junaruga
Copy link

@junaruga junaruga commented Feb 3, 2017

Hi,
I am using Fedora 24.
As I failed rake test in my local environment, let me send pull-request to see Travis CI test result.

$ ruby -v
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]

$ bundle -v
Bundler version 1.14.3

$ bundle install --path vendor/bundle

$ bundle list
Gems included by the bundle:
  * activesupport (5.0.1)
  * bundler (1.14.3)
  * concurrent-ruby (1.0.4)
  * i18n (0.8.0)
  * loofah (2.0.3)
  * mini_portile2 (2.1.0)
  * minitest (5.10.1)
  * nokogiri (1.7.0.1)
  * rails-dom-testing (2.0.2)
  * rails-html-sanitizer (1.0.3)
  * rake (12.0.0)
  * thread_safe (0.3.5)
  * tzinfo (1.2.2)

$ bundle exec rake test
/usr/local/ruby-2.4.0/bin/ruby -w -I"lib" -I"/home/jaruga/git/rails-html-sanitizer/vendor/bundle/ruby/2.4.0/gems/rake-12.0.0/lib" "/home/jaruga/git/rails-html-sanitizer/vendor/bundle/ruby/2.4.0/gems/rake-12.0.0/lib/rake/rake_test_loader.rb" "test/sanitizer_test.rb" "test/scrubbers_test.rb
...
  1) Failure:
SanitizersTest#test_strip_nested_tags [/home/jaruga/git/rails-html-sanitizer/test/sanitizer_test.rb:67]:
--- expected
+++ actual
@@ -1 +1 @@
-"Weia onclick='alert(document.cookie);'/>rdos"
+"Wei<a onclick='alert(document.cookie);'/>rdos"



  2) Failure:
SanitizersTest#test_should_sanitize_script_tag_with_multiple_open_brackets [/home/jaruga/git/rails-html-sanitizer/test/sanitizer_test.rb:363]:
Expected: alert("XSS");//
Actual: <alert("XSS");//<


  3) Failure:
SanitizersTest#test_strip_tags_with_many_open_quotes [/home/jaruga/git/rails-html-sanitizer/test/sanitizer_test.rb:102]:
Expected: ""
  Actual: "<<"


  4) Failure:
SanitizersTest#test_strip_invalid_html [/home/jaruga/git/rails-html-sanitizer/test/sanitizer_test.rb:61]:
Expected: ""
  Actual: "<<"


  5) Failure:
SanitizersTest#test_strip_links_with_tags_in_tags [/home/jaruga/git/rails-html-sanitizer/test/sanitizer_test.rb:128]:
--- expected
+++ actual
@@ -1 +1 @@
-"a href='hello'&gt;all <b>day</b> long/a&gt;"
+"&lt;a href='hello'&gt;all <b>day</b> long&lt;/a&gt;"


301 runs, 317 assertions, 5 failures, 0 errors, 0 skips
...

$ bundle exec vendor/bundle/ruby/2.4.0/bin/nokogiri -v
# Nokogiri (1.7.0.1)
    ---
    warnings: []
    nokogiri: 1.7.0.1
    ruby:
      version: 2.4.0
      platform: x86_64-linux
      description: ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]
      engine: ruby
    libxml:
      binding: extension
      source: packaged
      libxml2_path: "/home/jaruga/git/rails-html-sanitizer/vendor/bundle/ruby/2.4.0/gems/nokogiri-1.7.0.1/ports/x86_64-pc-linux-gnu/libxml2/2.9.4"
      libxslt_path: "/home/jaruga/git/rails-html-sanitizer/vendor/bundle/ruby/2.4.0/gems/nokogiri-1.7.0.1/ports/x86_64-pc-linux-gnu/libxslt/1.1.29"
      libxml2_patches: []
      libxslt_patches: []
      compiled: 2.9.4
      loaded: 2.9.4

$ rpm -q zlib-devel
zlib-devel-1.2.8-10.fc24.x86_64

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@junaruga junaruga force-pushed the feature/add-nokogiri-in-travis branch from fdb06e4 to 10213ad Compare February 3, 2017 20:04
@junaruga
Copy link
Author

junaruga commented Feb 3, 2017

https://travis-ci.org/rails/rails-html-sanitizer/jobs/198133121

The test is success for Travis. and libxml2, libxslt are same version with my environment.

@junaruga
Copy link
Author

junaruga commented Feb 6, 2017

Maybe situation is same with #49
In my case, I do not use system installed libxml2.

@kaspth
Copy link
Contributor

kaspth commented Mar 20, 2017

Not sure I understand what the issue is here? :)

I'll close for now.

@kaspth kaspth closed this Mar 20, 2017
@nirvdrum
Copy link

I think the issue is Travis shows all the tests for v1.0.3 passing, but anyone trying to run the tests locally is going to see a failure. It's not immediately clear why because we can't see what versions of anything being run are. #66 fixes some of the tests, but I still see two failures. More output in Travis would be helpful in debugging.

@kaspth
Copy link
Contributor

kaspth commented Feb 25, 2018

@nirvdrum looks like we're ignoring the Gemfile.lock. Do send a PR to ensure we check it in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants