tests: handle libxml 2.10.0 incorrectly-opened comment parsing #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxml 2.10.0 just dropped, and it contains a change to how incorrectly-opened HTML comments are parsed. This PR updates the tests to handle this behavior, which returns to the libxml 2.9.13-and-earlier behavior for comments starting with
<!.Related, see:
There was also a related issue opened on this repository:
Note that this behavior will be the default in a future Nokogiri release. This PR makes the tests compatible with all the known libxml2 behaviors.