Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve performance (slightly) #118

Merged
merged 2 commits into from Aug 23, 2021
Merged

improve performance (slightly) #118

merged 2 commits into from Aug 23, 2021

Commits on Aug 20, 2021

  1. test: rewrite test coverage for comments and PIs 

    to test behavior and not implementation.
    @flavorjones
    flavorjones committed Aug 20, 2021
    Copy the full SHA
    ab21d78 View commit details
    Browse the repository at this point in the history

  2. perf: PermitScrubber#scrub checks node.element? before node.comment? 

    Assuming elements are more common than comments, this is going to be
one less method call per node.
    @flavorjones
    flavorjones committed Aug 20, 2021
    Copy the full SHA
    b1fe437 View commit details
    Browse the repository at this point in the history