Fix failing test #112
Closed
Fix failing test #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the changes in released in Loofah 2.9.0 broke this test. I can't tell if this was an intended or unintended side effect of the change to support functions in shorthand CSS rule. I'm not sure how well documented this change was, but Loofah's tests were updated to reflect a different formatting in the commit that causes this behavior. I think it's safe to say that stripping the whitespace from rules like the one in this test is the expected behavior. The test should be updated to reflect the new formatting. Relevant links from Loofah: https://github.com/flavorjones/loofah/releases/tag/v2.9.0 flavorjones/loofah#200
Loofah 2.9.0 added support for "safe" CSS functions in shorthand CSS properties, e.g. `background: rgba(255,0,0,0.3);` Adding a couple of tests to ensure that functionality works in this gem too makes sense.
This was referenced Apr 7, 2021
|
Apologies, my PR at #113 potentially conflicts with this. I'm happy to rebase my PR, just let me know. |
|
Superseded by #113 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes one of the two failing tests. It seems like a somewhat undocumented change happened between Loofah 2.8.0 and 2.9.0, causing the output of scrubbed style attributes to look a bit different.
Additionally, it adds two tests to ensure the work being done here doesn't break the feature added in 2.9.0.
It's worth bringing up that there was a regression introduced in Loofah 2.9.0 and it has been patched today. That issue might pop up here as well.