Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xhr and xml_http_request due to rails 5 deprecation warning #32

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Shuiei
Copy link
Contributor

@Shuiei Shuiei commented Jan 31, 2017

DEPRECATION WARNING: xhrandxml_http_requestare deprecated and will be removed in Rails 5.1. Switch to e.g.post :create, params: { comment: { body: 'Honey bunny' } }, xhr: true.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Shuiei
Copy link
Contributor Author

Shuiei commented Jan 31, 2017

Do I need to make a condition to remove or not xhr and xml_http_request which depend on the rails version ?

@rafaelfranca
Copy link
Member

Yes, we need a conditional because this gem needs to work in Rails 5.0

@Shuiei
Copy link
Contributor Author

Shuiei commented Feb 1, 2017

Okay. I'm on it.

@Shuiei
Copy link
Contributor Author

Shuiei commented Feb 2, 2017

@rafaelfranca PR updated as requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants